Skip to content

Upgrade GitHub Actions for Node 24 compatibility#2841

Open
salmanmkc wants to merge 1 commit intowavetermdev:mainfrom
salmanmkc:upgrade-github-actions-node24
Open

Upgrade GitHub Actions for Node 24 compatibility#2841
salmanmkc wants to merge 1 commit intowavetermdev:mainfrom
salmanmkc:upgrade-github-actions-node24

Conversation

@salmanmkc
Copy link

Summary

Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Changes

Action Old Version(s) New Version Release Files
actions/download-artifact v4 v7 Release build-helper.yml
actions/upload-artifact v5 v6 Release build-helper.yml, testdriver-build.yml

Context

Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting March 4th, 2026.

Why this matters

  • Node 20 EOL: April 2026
  • Node 24 default: March 4th, 2026
  • Action: Update to latest action versions that support Node 24

Security Note

Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.

Testing

These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.

Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Feb 8, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

Walkthrough

Two GitHub Actions workflow files are updated with newer action versions. The build-helper.yml workflow bumps the upload-artifact action from v5 to v6 in two locations, the upload snapcraft logs action from v5 to v6, and the download-artifacts action from v4 to v7 in two locations. The testdriver-build.yml workflow upgrades the upload-artifact action from v5 to v6. No changes are made to control flow, conditional logic, or functional behavior—only version updates to external actions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Upgrade GitHub Actions for Node 24 compatibility' directly and clearly summarizes the main change: updating GitHub Actions versions to support Node 24.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, providing context about Node 20 deprecation, specific version updates, security considerations, and testing guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
.github/workflows/build-helper.yml (1)

187-191: download-artifact jumps from v4 directly to v7 — verify no intermediate breaking changes affect this workflow.

This is a 3-major-version jump (v4 → v7). actions/download-artifact@v7 now runs on Node.js 24, and v5/v6 were intermediate releases. The current usage (path: make, merge-multiple: true, no name filter) appears compatible based on the v7 README, and other projects have made the same v6→v7 upgrade with identical merge-multiple: true usage. However, given the large version gap, it's worth confirming the workflow runs successfully on a test branch before merging.

Note: The PR description states "Immutable SHA pins preserved (updated to latest release SHAs)" but all action references in these files use mutable version tags (e.g., @v7), not commit SHA pins. Consider either pinning to SHAs for supply-chain security or updating the PR description to reflect reality.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants