frontend/types/custom.d.ts (1)

133-133: ElectronApi typing for getPathForFile is consistent with preload implementation

The new getPathForFile(file: File): string entry matches what emain/preload.ts exposes, so consumers of getApi() will be correctly typed. The use of the global File type is consistent with other DOM usages in this file.

Minor nit: the // get-path-for-file comment follows the “IPC channel name” convention used for other methods, but this function doesn’t go over an IPC channel—it delegates directly to webUtils. If you rely on these comments as a mapping index, consider clarifying or omitting it, but this is purely cosmetic.

Based on learnings, these globals will be available everywhere without additional imports, so this addition should “just work” for all renderer code.

frontend/app/view/term/term.tsx (1)

10-10: Drag-and-drop file handling is solid; consider scoping to file drops, trimming logs, and tightening quoting

The overall flow—reading dropped files, resolving full paths via getApi().getPathForFile, and inserting a space-separated list at the cursor—is good and matches the PR intent.

A few refinements to consider:

1. Don’t intercept non-file drops unless necessary

handleDragOver, handleDrop, handleDragEnter, and handleDragLeave always call preventDefault/stopPropagation. That will also swallow non-file drops (e.g., text/URL drags), and may interfere with xterm.js’ default behavior for dropping text into the terminal.

You can gate the custom behavior to only when files are present:

-    // Handle drag and drop
-    const handleDragOver = React.useCallback((e: React.DragEvent) => {
-        e.preventDefault();
-        e.stopPropagation();
-        // Indicate that we can accept the drop
-        e.dataTransfer.dropEffect = "copy";
-    }, []);
+    // Handle drag and drop of local files
+    const isFileDrop = (e: React.DragEvent) =>
+        Array.from(e.dataTransfer?.types ?? []).includes("Files");
+
+    const handleDragOver = React.useCallback((e: React.DragEvent) => {
+        if (!isFileDrop(e)) {
+            return;
+        }
+        e.preventDefault();
+        e.stopPropagation();
+        // Indicate that we can accept the drop
+        e.dataTransfer.dropEffect = "copy";
+    }, []);
@@
-    const handleDrop = React.useCallback((e: React.DragEvent) => {
-        e.preventDefault();
-        e.stopPropagation();
-
-        // Get files from the drop
-        const files = Array.from(e.dataTransfer.files);
+    const handleDrop = React.useCallback((e: React.DragEvent) => {
+        if (!isFileDrop(e)) {
+            return;
+        }
+        e.preventDefault();
+        e.stopPropagation();
+
+        // Get files from the drop
+        const files = Array.from(e.dataTransfer.files);
@@
-    const handleDragEnter = React.useCallback((e: React.DragEvent) => {
-        e.preventDefault();
-        e.stopPropagation();
-    }, []);
+    const handleDragEnter = React.useCallback((e: React.DragEvent) => {
+        if (!isFileDrop(e)) {
+            return;
+        }
+        e.preventDefault();
+        e.stopPropagation();
+    }, []);
@@
-    const handleDragLeave = React.useCallback((e: React.DragEvent) => {
-        e.preventDefault();
-        e.stopPropagation();
-    }, []);
+    const handleDragLeave = React.useCallback((e: React.DragEvent) => {
+        if (!isFileDrop(e)) {
+            return;
+        }
+        e.preventDefault();
+        e.stopPropagation();
+    }, []);

2. Use debug logger instead of console.log

The multiple console.log/console.error calls ("Drop files:", "Paths to insert:", "Final path string:") are useful during development but can be noisy in production. Since this module already has const dlog = debug("wave:term");, consider using that or removing most logs once you’re confident in the behavior:

-        console.log("Drop files:", files);
@@
-                console.log("File:", file.name, "-> Full path:", fullPath);
+                dlog("file drop: %s -> %s", file.name, fullPath);
@@
-        console.log("Paths to insert:", paths);
@@
-        console.log("Final path string:", pathString);

3. Quoting edge cases (optional)

Right now, only paths containing a space are wrapped in double quotes, and embedded double quotes are not escaped. That’s fine for most cases, but if you want to be more robust (especially on Windows with unusual folder names), you could:

• Always use double quotes and escape embedded "; or
• Reuse any existing shell-quoting helper you might have in the codebase.

Example (if you’re okay always quoting):

-        const pathString = paths.map(path => {
-            // Quote paths that contain spaces
-            if (path.includes(" ")) {
-                return `"${path}"`;
-            }
-            return path;
-        }).join(" ");
+        const pathString = paths
+            .map((path) => `"${path.replace(/"/g, '\\"')}"`)
+            .join(" ");

4. Optional UX tweak: keep or restore focus

If you notice that dropping files causes the terminal to lose focus, you may want to call model.giveFocus() after sending the path so typing can continue seamlessly.

Please verify whether xterm.js (or your TermWrap) previously supported dropping plain text/URLs into the terminal and whether that behavior is still desired alongside file-path drops.

Also applies to: 352-403, 405-413, 416-423

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: sawka
Repo: wavetermdev/waveterm PR: 2504
File: frontend/app/aipanel/aipanel-contextmenu.ts:15-16
Timestamp: 2025-11-01T00:57:23.025Z
Learning: In the waveterm codebase, types defined in custom.d.ts are globally available and do not require explicit imports. Backend types defined in gotypes.d.ts are also globally available.

Learnt from: sawka
Repo: wavetermdev/waveterm PR: 2465
File: frontend/app/onboarding/onboarding-upgrade.tsx:13-21
Timestamp: 2025-10-21T05:09:26.916Z
Learning: In the waveterm codebase, clientData is loaded and awaited in wave.ts before React runs, ensuring it is always available when components mount. This means atoms.client will have data on first render.