Skip to content

fix: use normal string concatenation for cross-browser support #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
germanattanasio merged 1 commit into from
Sep 18, 2018
+5 −5
Merged

fix: use normal string concatenation for cross-browser support #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions speech-to-text/get-models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ module.exports = function getModels(options) {
};
var url = options.url || 'https://stream.watsonplatform.net/speech-to-text/api';
if (options.access_token) {
url = `${url}/v1/models?access_token=${options.access_token}`;
url = url + '/v1/models?access_token=' + options.access_token;
} else {
url = `${url}/v1/models?access_token=${options.token}`;
url = url + '/v1/models?access_token=' + options.token;
}
return fetch(url, reqOpts)
.then(function(response) {
Expand Down
4 changes: 2 additions & 2 deletions text-to-speech/get-voices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ module.exports = function getVoices(options) {
};
var url = options.url || 'https://stream.watsonplatform.net/text-to-speech/api';
if (options.access_token) {
url = `${url}'/v1/voices?watson-token='${options.access_token}`;
url = url + '/v1/voices?watson-token=' + options.access_token;
} else {
url = `${url}'/v1/voices?watson-token='${options.token}`;
url = url + '/v1/voices?watson-token=' + options.token;
}
return fetch(url, reqOpts)
.then(function(response) {
Expand Down
2 changes: 1 addition & 1 deletion text-to-speech/synthesize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ module.exports = function synthesize(options) {
var url = options.url || 'https://stream.watsonplatform.net/text-to-speech/api';
var audio = options.element || new Audio();
audio.crossOrigin = 'anonymous';
audio.src = `${url}/v1/synthesize?${qs.stringify(pick(options, QUERY_PARAMS_ALLOWED))}`;
audio.src = url + '/v1/synthesize?' + qs.stringify(pick(options, QUERY_PARAMS_ALLOWED));
if (options.autoPlay !== false) {
audio.play();
}
Expand Down