perf: move wdc dependency to devDependencies for smaller package size#133
Merged
germanattanasio merged 1 commit intomasterfrom Jul 17, 2019
Merged
perf: move wdc dependency to devDependencies for smaller package size#133germanattanasio merged 1 commit intomasterfrom
germanattanasio merged 1 commit intomasterfrom
Conversation
germanattanasio
approved these changes
Jul 17, 2019
|
🎉 This PR is included in version 0.36.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package
watson-developer-cloudis not actually used anywhere in the code, just in the tests/examples. Therefore, there is no reason for it to be included in the production dependencies. This PR moves the package todevDependenciesso that it will no longer be included in the production release.Marking this as a performance change, so it will trigger a patch release.