Skip to content

9388 gha #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apaparazzi0329 merged 22 commits into from
Jun 21, 2021
Merged

9388 gha #791

apaparazzi0329 merged 22 commits into from
Jun 21, 2021

Conversation

@Mikemosca
Copy link
Contributor

@Mikemosca Mikemosca commented Jun 17, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #791 (e318bfb) into master (83370b7) will increase coverage by 47.56%.
The diff coverage is 85.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #791       +/-   ##
===========================================
+ Coverage   43.86%   91.43%   +47.56%     
===========================================
  Files          25       25               
  Lines       28001    31752     +3751     
===========================================
+ Hits        12283    29032    +16749     
+ Misses      15718     2720    -12998
Impacted Files Coverage Δ
ibm_watson/__init__.py 100.00% <ø> (ø)
ibm_watson/assistant_v1.py 90.76% <ø> (+45.87%) ⬆️
ibm_watson/assistant_v2.py 90.30% <ø> (+45.97%) ⬆️
ibm_watson/compare_comply_v1.py 93.02% <ø> (+50.59%) ⬆️
ibm_watson/discovery_v1.py 93.04% <ø> (+48.83%) ⬆️
ibm_watson/discovery_v2.py 92.08% <ø> (+57.58%) ⬆️
ibm_watson/natural_language_understanding_v1.py 93.06% <ø> (+50.54%) ⬆️
ibm_watson/speech_to_text_v1.py 92.75% <ø> (+47.05%) ⬆️
ibm_watson/speech_to_text_v1_adapter.py 17.64% <ø> (-64.71%) ⬇️
ibm_watson/text_to_speech_adapter_v1.py 20.00% <ø> (-66.67%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c8e72...e318bfb. Read the comment docs.

@apaparazzi0329 apaparazzi0329 self-requested a review June 21, 2021 18:49
@apaparazzi0329
Copy link
Contributor

apaparazzi0329 commented Jun 21, 2021

@Mikemosca I think this is ready to merge. Can you give this PR a last look and squash and merge when ready?

@Mikemosca
Copy link
Contributor Author

Mikemosca commented Jun 21, 2021

LGTM, I could not approve because I am not a reviewer. I will give you the honor to merge it!

apaparazzi0329
apaparazzi0329 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apaparazzi0329 apaparazzi0329 merged commit b9b7d8a into master Jun 21, 2021
@watson-github-bot
Copy link
Collaborator

watson-github-bot commented Jun 28, 2021

🎉 This PR is included in version 5.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaparazzi0329 apaparazzi0329 apaparazzi0329 approved these changes

Assignees

No one assigned

Labels

DO NOT MERGE released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mikemosca @codecov-commenter @apaparazzi0329 @watson-github-bot