Skip to content

Conversation

@ehdsouza
Copy link
Contributor

  • Updated .releaserc with the proper updates from @padamstx 's PR in core.
  • Removed the [skip ci] commit message which I had added as a trial
  • update travis.yml with pip3

@padamstx
Copy link

One question I had is... Appveyor is a CI/CD tool sort of like Travis. Just wondering why this project is built on both Travis AND Appveyor???

Copy link

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehdsouza
Copy link
Contributor Author

ehdsouza commented Nov 21, 2019

@padamstx Appveyor checks tests against Windows OS

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ca54907). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #713   +/-   ##
=========================================
  Coverage          ?   39.82%           
=========================================
  Files             ?       24           
  Lines             ?    21472           
  Branches          ?        0           
=========================================
  Hits              ?     8551           
  Misses            ?    12921           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca54907...d17593d. Read the comment docs.

@ehdsouza ehdsouza merged commit 86cfdfe into master Nov 22, 2019
@ehdsouza ehdsouza deleted the semrelease-correct branch November 22, 2019 20:21
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants