-
Notifications
You must be signed in to change notification settings - Fork 823
Update integration tests and semantic updates #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lready in integration test
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 37.8% 39.82% +2.02%
==========================================
Files 24 24
Lines 21472 21472
==========================================
+ Hits 8117 8551 +434
+ Misses 13355 12921 -434
Continue to review full report at Codecov.
|
padamstx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to fix one thing in .releaserc
| "branch": "master", | ||
| "verifyConditions": [], | ||
| "verifyConditions": ["@semantic-release/changelog", "@semantic-release/github"], | ||
| "debug": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably don't need the "debug" field here, but also ok to leave it you want... I think it just results in more output in the travis build log
.releaserc
Outdated
| "verifyConditions": ["@semantic-release/changelog", "@semantic-release/github"], | ||
| "debug": true, | ||
| "prepare": [ | ||
| "@semantic-release/changelog", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "exec" step needs to be done first, then changelog, then git. You can see the python-core file as an example.
mediumTaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
|
Complexity decreasing per file
==============================
+ test/integration/test_examples.py -1
See the complete overview on Codacy |
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR does the following:
Also, @padamstx could you review the semantic release updates?