Skip to content

Import the correct class in speaker_text_to_speech example #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehdsouza merged 1 commit into from
Nov 7, 2019
Merged

Import the correct class in speaker_text_to_speech example #704

ehdsouza merged 1 commit into from
Nov 7, 2019

Conversation

@SiddhantNaik17
Copy link
Contributor

@SiddhantNaik17 SiddhantNaik17 commented Nov 7, 2019

SpeechToTextV1 was used instead of TextToSpeechV1

@codecov-io
Copy link

codecov-io commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #704 into master will decrease coverage by 1.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #704      +/-   ##
=========================================
- Coverage   39.67%   37.8%   -1.87%     
=========================================
  Files          24      24              
  Lines       21472   21472              
=========================================
- Hits         8518    8117     -401     
- Misses      12954   13355     +401
Impacted Files Coverage Δ
ibm_watson/text_to_speech_adapter_v1.py 20% <0%> (-66.67%) ⬇️
ibm_watson/speech_to_text_v1_adapter.py 17.64% <0%> (-64.71%) ⬇️
ibm_watson/websocket/synthesize_listener.py 33.33% <0%> (-47.92%) ⬇️
ibm_watson/websocket/audio_source.py 42.85% <0%> (-42.86%) ⬇️
ibm_watson/websocket/recognize_listener.py 26.36% <0%> (-42.73%) ⬇️
ibm_watson/websocket/synthesize_callback.py 90% <0%> (-10%) ⬇️
...bm_watson/websocket/recognize_abstract_callback.py 90.9% <0%> (-9.1%) ⬇️
ibm_watson/compare_comply_v1.py 28.7% <0%> (-7.28%) ⬇️
ibm_watson/visual_recognition_v4.py 36.9% <0%> (-2.37%) ⬇️
ibm_watson/visual_recognition_v3.py 38.58% <0%> (-0.73%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec1da7...3a6375b. Read the comment docs.

@ehdsouza ehdsouza self-requested a review November 7, 2019 15:34
ehdsouza
ehdsouza approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@ehdsouza ehdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ehdsouza ehdsouza merged commit 1d6cc98 into watson-developer-cloud:master Nov 7, 2019
@watson-github-bot
Copy link
Collaborator

watson-github-bot commented Nov 11, 2019

🎉 This PR is included in version 4.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ehdsouza ehdsouza ehdsouza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SiddhantNaik17 @codecov-io @watson-github-bot @ehdsouza