-
Notifications
You must be signed in to change notification settings - Fork 527
V8 rc1 #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
V8 rc1 #1082
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
9f21323
ci: Fix reference to script to generate Javadoc index file
lpatino10 c44118e
feat: Regenerate all services other than Assistant v1
lpatino10 ccbd5da
feat(Assistant v1): Regenerate service
lpatino10 179ed46
test(Assistant): Update tests
lpatino10 55e7e06
test(Compare and Comply): Update tests
lpatino10 d5fb5f2
refactor(Discovery): Clean up custom QueryAggregation deserializer
lpatino10 4bc3d07
chore(Discovery): Apply manual changes
lpatino10 6409d5f
test(Discovery): Update tests
lpatino10 853e3c7
chore(Language Translator): Fix generator template error
lpatino10 b982379
test(Language Translator): Update tests
lpatino10 b33ce86
test(Natural Language Classifier): Update tests
lpatino10 59a7d94
test(Natural Language Understanding): Update tests
lpatino10 845120a
test(Personality Insights): Update tests
lpatino10 a162667
chore(Speech to Text): Apply manual changes
lpatino10 a29afe9
test(Speech to Text): Update tests
lpatino10 e2dae74
test: Use interface when creating authenticators
lpatino10 7b7b138
chore(Text to Speech): Apply manual changes
lpatino10 873369f
test(Text to Speech): Update tests
lpatino10 1db8776
test(Tone Analyzer): Update tests
lpatino10 79dfdf1
test(Visual Recognition): Update tests
lpatino10 1e33378
build: Update core dependency
lpatino10 5a70ef6
style: Address checkstyle complaints
lpatino10 fe142ed
docs: Update all READMEs with auth changes and new core features
lpatino10 fe98920
docs: Update examples to use new library
lpatino10 c5c9f5a
build: Update version numbers
lpatino10 8d9c314
ci: Disable semantic-release for release candidate
lpatino10 7efb5b8
refactor: Use better naming for reserved word vars
lpatino10 b667b16
docs(README): Add snippet about ICP auth
lpatino10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this I wonder if we need to keep an example for ICP authentication. This would be using BasicAuthenticator and disabling ssl verification. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that might be worth it. I don't know the numbers on people using the SDKs on ICP but it's probably similar to CP4D so it can't hurt 🤷♀