[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.3 #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14896210
There was a problem hiding this comment.
Pull request overview
This PR upgrades urllib3 from version 2.0.7 to 2.6.3 to address security vulnerability SNYK-PYTHON-URLLIB3-14896210. urllib3 is a transitive dependency of the requests library used in this project.
Changes:
- Adds explicit urllib3 version constraint to pin the minimum version to 2.6.3 for security purposes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,2 +1,3 @@ | |||
| docopt | |||
| requests | |||
| urllib3>=2.6.3 # not directly required, pinned by Snyk to avoid a vulnerability | |||
There was a problem hiding this comment.
The version constraint uses ">=" which will allow any version 2.6.3 or higher, including major version 3.x if it exists. This could potentially introduce breaking changes. Consider using a more restrictive constraint such as "urllib3>=2.6.3,<3" to prevent automatic upgrades to incompatible major versions.
Suggested change
| urllib3>=2.6.3 # not directly required, pinned by Snyk to avoid a vulnerability | |
| urllib3>=2.6.3,<3 # not directly required, pinned by Snyk to avoid a vulnerability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
DOH-Dig/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.