Skip to content

war-911: generic code in all selenium kws converted to a util - #47

Open
Annam16 wants to merge 22 commits into
developfrom
feature/WAR-911-github
Open

war-911: generic code in all selenium kws converted to a util#47
Annam16 wants to merge 22 commits into
developfrom
feature/WAR-911-github

Conversation

@Annam16

@Annam16 Annam16 commented Jun 27, 2017

Copy link
Copy Markdown

modified selenium action files to make it as a generic one

@Annam16 Annam16 self-assigned this Jun 27, 2017
@Annam16
Annam16 requested review from bjrr and sanikakulkarni June 27, 2017 06:25

@sanikakulkarni sanikakulkarni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Annam16,
It seems like the pylint for browser_actions.py and element_operations.py in the pull request is lower than the original browser_actions.py and element_operations.py respectively. Please correct the pylint errors in that file so that the Travis CI job passes.

Actions.SeleniumActions.browser_actions            has been rated at 7.24/10 (previous run: 7.57/10, -0.33)
 Actions.SeleniumActions.elementlocator_actions     has been rated at 7.87/10 (previous run: 7.47/10, +0.39)
 Actions.SeleniumActions.elementoperation_actions   has been rated at 6.07/10 (previous run: 7.58/10, -1.51)
 Actions.SeleniumActions.verify_actions             has been rated at 7.92/10 (previous run: 6.25/10, +1.67)
 Actions.SeleniumActions.wait_actions               has been rated at 6.67/10 (previous run: 6.65/10, +0.01)
 Framework.Utils.selenium_Utils                     has been rated at 8.87/10 (previous run: 8.37/10, +0.50)

@Annam16
Annam16 force-pushed the feature/WAR-911-github branch from b701594 to ec925f8 Compare July 13, 2017 10:25
@sanikakulkarni

Copy link
Copy Markdown
Contributor

Hi @Annam16,

Please hold off on working on this pull request. Some pylint changes need to go into 'develop' - this would mostly resolve the pylint failure in this pull request.

@Annam16

Annam16 commented Aug 28, 2017

Copy link
Copy Markdown
Author

@sanikakulkarni @bjrr
The travis failure is due to the initial selenium design of using too many unused variables and too many local variables.
Either we have to completely change the selenium design to comply with PEP8 standards or create exceptions in travis for selenium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants