This repository was archived by the owner on May 5, 2022. It is now read-only.
Add preload header on subresource example #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrigorik
reviewed
Aug 18, 2017
index.html
Outdated
| fetch group.</p> | ||
| </div> | ||
| <div class="note"> | ||
| Link HTTP header should trigger preloads on responses to navigational |
Member
There was a problem hiding this comment.
Technically, I think this could be read as no preload for worker responses? The issue is that "subresource" has specific definition in Fetch. How about..
Link HTTP response header should be processed for all destinations.
WDYT?
igrigorik
reviewed
Aug 18, 2017
index.html
Outdated
| fetch group.</p> | ||
| </div> | ||
| <div class="note"> | ||
| Link HTTP response header should be processed for all <a>request destination</a>s. |
Member
There was a problem hiding this comment.
https://github.com/w3c/respec/wiki/User's-Guide#definitions-and-linking, or.. "all types of request destination"?
igrigorik
approved these changes
Aug 23, 2017
Member
|
👍 thanks Yoav! |
yoavweiss
added a commit
to yoavweiss/preload
that referenced
this pull request
Aug 30, 2017
* Only use double-quotes in header examples * Add a note regarding the applicability of Link preload headers to subresource responses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with the tests, closes #92
Preview | Diff