Merged
Conversation
Updates autonomous custom elements and form associated custom elements to indicate that they have no corresponding role if an author did not define a role in the custom element’s `ElementInternals`. The allowed roles and properties column has been updated to indicate that if a custom element has an author defined role, then the allowed roles to that element must be in adherence to the defined role.
carmacleod
reviewed
Feb 3, 2020
carmacleod
reviewed
Feb 3, 2020
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Contributor
|
Looks good. |
Member
Author
|
yes, no references presently. we should make them |
|
whatwg/html#4658 was merged. |
Contributor
|
Also w3c/aria#984 was merged. So I think the "not ready for merge" label can be removed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180
Updates autonomous custom elements and form associated custom elements to indicate that they have no corresponding role if an author did not define a role in the custom element’s
ElementInternals.The allowed roles and properties column has been updated to indicate that if a custom element has an author defined role, then the allowed roles to that element must adhere to the defined role of the custom element.
I'm thinking it's probably a good idea to add an example, at the end of section 2, to help demonstrate proper conformance here.
e.g.
<my-element>with no role defined from itsElementInternalscan accept any role.but if
<my-check>were created and had its role defined via its internals...(example from the pending PR to the HTML spec)
Then only roles allowed on a checkbox would be allowed on this custom element.
That all said, we shouldn't merge this update until the linked HTML and ARIA issues in #180 are merged.
cc @carmacleod
Preview | Diff