Skip to content

feat: add aria-checked support to gridcell and row#2390

Open
smhigley wants to merge 3 commits intomainfrom
gridcell-aria-checked
Open

feat: add aria-checked support to gridcell and row#2390
smhigley wants to merge 3 commits intomainfrom
gridcell-aria-checked

Conversation

@smhigley
Copy link
Copy Markdown
Contributor

@smhigley smhigley commented Dec 3, 2024 •
edited by pr-preview bot
Loading

Closes #1960

Adds aria-checked as a supported state to gridcell, with the same wording around combining aria-checked & aria-selected as on option and treeitem. The aria-checked support also inherits into columnheader and rowheader.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests: N/A
  • "user agent MUST" tests: N/A
  • Browser implementations (link to issue or commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations? Likely not, since this should come from browser mappings
  • Related APG Issue/PR: N/A
  • MDN Issue/PR:

Preview | Diff

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 632977c
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67cb2a207abba40008836728
😎 Deploy Preview https://deploy-preview-2390--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adampage
adampage approved these changes Dec 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Otherwise, this LGTM! 🚀

@smhigley
Copy link
Copy Markdown
Contributor Author

smhigley commented Dec 5, 2024

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Heh, my personal opinion is still that aria-checked and aria-selected never belong on the same node together. That debate happened a while ago though, and the current wording (borrowed from option and treeitem) is the result 🤪

@smhigley smhigley changed the title feat: add aria-checked support to gridcell feat: add aria-checked support to gridcell and row Dec 9, 2024
hidde
hidde approved these changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hidde hidde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jnurthen jnurthen removed the request for review from hidde-logius December 19, 2024 18:23
@jnurthen
Copy link
Copy Markdown
Member

jnurthen commented Dec 19, 2024

@mcking65 can you please review

This was referenced Dec 20, 2024
Open
Open
@pkra pkra force-pushed the gridcell-aria-checked branch from ddc6426 to 28461ba Compare March 7, 2025 17:16
@pkra
Copy link
Copy Markdown
Member

pkra commented Mar 7, 2025

@smhigley rebased on main. I hope I didn't do any damage.

@spectranaut spectranaut moved this from All PRS to Needs Review in ARIA Normative PR Tracking Jun 13, 2025
@spectranaut spectranaut requested a review from front-endian June 19, 2025 17:44
front-endian
front-endian approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown

@front-endian front-endian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; really clear and easy to understand!

(Despite having seen some complex tables where this could be used, I really hope people respect the "extremely rare" part of this. 😅)

@spectranaut spectranaut moved this from Needs Review to Reviewed, other needs in ARIA Normative PR Tracking Aug 26, 2025
@spectranaut
Copy link
Copy Markdown
Contributor

spectranaut commented Jan 13, 2026

Needs bugs on browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adampage adampage adampage approved these changes

@front-endian front-endian front-endian approved these changes

@mcking65 mcking65 Awaiting requested review from mcking65

+1 more reviewer

@hidde hidde hidde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spec:aria

Projects

ARIA Normative PR Tracking
Status: Reviewed, other needs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider supporting aria-checked on gridcells

7 participants

@smhigley @jnurthen @pkra @spectranaut @hidde @adampage @front-endian