Update authoring requirement for aria-selected on options#1719
Merged
Conversation
some odd white spacing fixes and inconsistent period/capitalization between list item sentences.
scottaohara
reviewed
Apr 8, 2022
Contributor
|
In my opinion, this change should also be made for treeitem and not only for option. |
chlane
approved these changes
Apr 20, 2022
chlane
approved these changes
Apr 20, 2022
mcking65
approved these changes
Apr 21, 2022
Contributor
mcking65
left a comment
mcking65
left a comment
There was a problem hiding this comment.
Thank you @smhigley! This looks great.
I agree with @JAWS-test that the same language would work in treeitem; that could be a separate PR. The related issue is about option.
Member
|
ready to merge |
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
A different solution for #1661, discussed on 4/7 and summarized in this comment: #1661 (comment) I wrangled the existing wording around single vs. multiselect a little because the new `SHOULD` text about `aria-selected` overlapped with the existing single vs. multi-select wording, so I consolidated a bit. * update to author requirement for aria-selected on options * minor cleanup some odd white spacing fixes and inconsistent period/capitalization between list item sentences. * and again with the spacing... * fix spacing, update checked/selected value wording Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A different solution for #1661, discussed on 4/7 and summarized in this comment: #1661 (comment)
I wrangled the existing wording around single vs. multiselect a little because the new
SHOULDtext aboutaria-selectedoverlapped with the existing single vs. multi-select wording, so I consolidated a bit.Preview | Diff