Conversation
This PR requires #1703 be merged.
chlane
approved these changes
Mar 31, 2022
Contributor
chlane
left a comment
chlane
left a comment
There was a problem hiding this comment.
I agree that aria-label and aria-labelledby can be used to label a figure element
charmarkk
approved these changes
Mar 31, 2022
Contributor
charmarkk
left a comment
charmarkk
left a comment
There was a problem hiding this comment.
I agree, and editorial looks good.
smhigley
reviewed
Apr 1, 2022
scottaohara
commented
Apr 1, 2022
MelSumner
approved these changes
Apr 27, 2022
Contributor
MelSumner
left a comment
MelSumner
left a comment
There was a problem hiding this comment.
This looks good. Approved the related PR as well. 👍
Member
|
@smhigley is this one ok by you now? |
smhigley
approved these changes
Sep 1, 2022
Member
|
@scottaohara would you be able to resolve the merge conflicts? |
Member
Author
|
@pkra done |
pkra
pushed a commit
that referenced
this pull request
Sep 2, 2022
* update figure role This PR requires #1703 be merged. * Update index.html * revisions per sarah's review * further updates to figure def
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
* update figure role This PR requires #1703 be merged. * Update index.html * revisions per sarah's review * further updates to figure def
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires #1703 be merged.
Preview | Diff