Conversation
closes #1083 adds initial draft content to the handling author error section to call out expected behavior for `form` and `region` landmark roles which have not been provided accessible names.
smhigley
left a comment
There was a problem hiding this comment.
For form, this looks like a substantive change from what happens currently. It looks like <div role="form"> is still exposed as a form landmark even without a name (checked Firefox and Chromium on this quick example: https://jsfiddle.net/py96hL7b/, and Safari appears to map to Group whether named or not).
Is that something we actually want to change? Out of all landmarks with name required, I can most see form being valuable to expose anyway.
|
Fair point. The intent here was to align how HTML AAM treats unnamed If we do not want to make this change then this is really just to better specify what happens with |
|
To be fair, aligning to an unnamed |
|
Adding agenda label to hopefully get this quickly resolved. Solutions - keep PR as is if people agree that an unnamed Alternative, we decide that |
|
TODO: make sure that this PR indicates that the fallback role for the element is what is to be exposed AND if someone were to do |
|
@smhigley @MelSumner I have finished my TODO, so this is ready to review again. @cookiecrook I added you as a reviewer as it was your comment (if i recall correctly) that prompted me to add the new bits to this PR. If you do not wish to review, please ignore. |
MelSumner
left a comment
There was a problem hiding this comment.
As an aside, I wonder if browsers could add some sort of warning to the console log. 🤔
Anyway, thank you for doing this work @scottaohara 👍 ![]()
|
question, but should I also update the
to
bold "named" for emphasis, but not because i think it should be bold |
|
@scottaohara that sounds like a good idea to me 👍 |
|
thanks @smhigley. added some words to those lines for each role. |
|
I agree with this change. If a form exists, it probably represents the purpose of the page and AT users should at least understand they are interacting with a form, even if it is unnamed. Anonymous regions aren't perfect but they still can provide a sense of structure for AT users. |
closes #1083 * adds initial draft content to the handling author error section to call out expected behavior for `form` and `region` landmark roles which have not been provided accessible names. * update section to talk about fallback and implicit role * add mention of naming to region/form landmark sentence
closes #1083
adds initial draft content to the handling author error section to call out expected behavior for
formandregionlandmark roles which have not been provided accessible names.Preview | Diff