Skip to content

Revert new labeling mechanisms#1491

Merged
jnurthen merged 3 commits intomainfrom
jnurthen/issue1490
Jun 30, 2021
Merged

Revert new labeling mechanisms#1491
jnurthen merged 3 commits intomainfrom
jnurthen/issue1490

Conversation

@jnurthen
Copy link
Copy Markdown
Member

@jnurthen jnurthen commented May 26, 2021 •
edited by pr-preview bot
Loading

Fixes #1490

Preview | Diff

scottaohara
scottaohara reviewed May 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only thing that stuck out to me was that the following sections were still rendered in the preview, but had no content:

5.2.8.6 Roles Supporting Name from Encapsulation
5.2.8.7 Roles Supporting Name from Legend

assuming a script needs to be updated in this PR as well to remove those?

@jnurthen
Copy link
Copy Markdown
Member Author

jnurthen commented May 26, 2021

only thing that stuck out to me was that the following sections were still rendered in the preview, but had no content:

5.2.8.6 Roles Supporting Name from Encapsulation
5.2.8.7 Roles Supporting Name from Legend

assuming a script needs to be updated in this PR as well to remove those?

I left them so I could make sure I got every instance. I'll remove them (not a script thing - its a matter of removing the sections from the document - although I should probably remove the script support too to simplify it)

@jnurthen jnurthen requested review from MelSumner and charmarkk May 27, 2021 17:10
MelSumner
MelSumner reviewed May 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jnurthen jnurthen merged commit 103dec9 into main Jun 30, 2021
@pkra pkra mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottaohara scottaohara scottaohara left review comments

@MelSumner MelSumner MelSumner left review comments

@charmarkk charmarkk charmarkk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revert new labeling mechanisms

4 participants

@jnurthen @scottaohara @MelSumner @charmarkk