Tighten up Required Context Role: group#1359
Conversation
- only if group is contained in primary context role
scottaohara
left a comment
scottaohara
left a comment
There was a problem hiding this comment.
i think this helps clarify. thank you
|
@mcking65 This PR also touches the menuitem roles. After both PRs go in, we can look at whether the menuitem prose needs to be updated to match the new prose in listbox and tree. I'll open an issue as a reminder. |
jnurthen
left a comment
jnurthen
left a comment
There was a problem hiding this comment.
If we are adding this new concept we should be complete. I think we are missing changes to required context role on
row (table -> rowgroup , grid -> rowgroup, treegrid -> rowgroup)
Good catch, @jnurthen ! |
|
This is ready for final review. The latest commit reorders group/rowgroup items that are required context roles for option, treeitem, and menuitem roles so that the group comes first, followed by left arrow, followed by the contained item role, as suggested by @jnurthen in today's call. This uses a left-pointing arrow character in an |
MelSumner
left a comment
MelSumner
left a comment
There was a problem hiding this comment.
This looks good, thank you!
5 participants
The group role can only be a required context role if the group is contained in the primary context role.
So:
optioncan only be in a group if the group is in alistboxtreeitemcan only be in a group if the group is in atreemenuitem[checkbox|radio]can only be in a group if the group is in amenuormenubarPreview (#option) (#treeitem) (#menuitem) | Diff