Add suggestion role by aleventhal · Pull Request #1134 · w3c/aria

aleventhal · 2019-12-11T18:02:20Z

Relates to ARIA Annotations, issue #749

Preview | Diff

Relates to ARIA Annotations, issue #749

Relates to ARIA Annotations, issue #749 Fix tabs Fix tabs

…_role

index.html

joanmarie

In addition to addressing the wording-related comments and questions, please also add suggestion to the appropriate list under https://w3c.github.io/aria/#roles_categorization

carmacleod

I think the words are ok, but I think this role needs an example to fully explain it.
I had to look at the explainer to understand where the markup would go (it's embedded in the content).
I think the -cat/+dog code example from the explainer would be helpful here.

carmacleod

Thanks for the example, @aleventhal!
Looks good!
+1

joanmarie · 2020-01-24T19:27:24Z

Looks good to me overall, but as I'm sitting here implementing support for this role in Orca, I have a question: Your text says:

The suggested change must be present as child content, as an insertion, a deletion, or one of each.

Can there be other children, like a paragraph explaining why the proposed insertion and/or deletion should be made? Or a time stamp? Or am I guaranteed to only find insertion and/or deletion children?

Arguably Orca should handle both scenarios because authors. But it would be nice to know (and perhaps see text in the spec stating) what the right usage looks like. Also, if we do want to prevent authors from putting non-insertion/deletion children in a suggestion, adding this statement to the spec should then cause it to be checked by validators.

…ion but may be combined with annotations

aleventhal · 2020-01-24T19:51:27Z

@joanmarie PTAL, I updated the text to make this more clear.

Looks good to me overall, but as I'm sitting here implementing support for this role in Orca, I have a question: Your text says:

The suggested change must be present as child content, as an insertion, a deletion, or one of each.

Can there be other children, like a paragraph explaining why the proposed insertion and/or deletion should be made? Or a time stamp? Or am I guaranteed to only find insertion and/or deletion children?

Arguably Orca should handle both scenarios because authors. But it would be nice to know (and perhaps see text in the spec stating) what the right usage looks like. Also, if we do want to prevent authors from putting non-insertion/deletion children in a suggestion, adding this statement to the spec should then cause it to be checked by validators.

index.html

Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>

joanmarie

I like it! Thanks for adding clarity regarding other possible children!!

mcking65

No big concerns, but I think it is very important that the normative language be specific, especially wrt the responsible party. Most of my suggestions are related to that concern.

index.html

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

aleventhal · 2020-02-07T14:30:00Z

@mcking65 I think I got everything, but I needed to do some polish after as there was an incomplete sentence snippet that remained. Can you take a look?

index.html

Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>

mcking65

Looks good. I just made one minor editorial suggestion.

index.html

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

* Relates to ARIA Annotations, issue #749 Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com> Co-Authored-By: Matt King <a11yThinker@Gmail.com>

Aaron Leventhal added 6 commits December 11, 2019 12:57

Add suggestion role

fca5644

Relates to ARIA Annotations, issue #749

Fix tabs

07e8c9b

Fix tabs

b6ec793

Add suggestion role

3de920d

Relates to ARIA Annotations, issue #749 Fix tabs Fix tabs

Merge branch 'suggestion_role' of github.com:w3c/aria into suggestion…

37637d0

…_role

Fix tabs

74ddc01

jnurthen added the Agenda label Dec 18, 2019

aleventhal mentioned this pull request Dec 19, 2019

Place to collect feedback on ARIA Annotations proposal #1109

Closed

joanmarie reviewed Jan 6, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

joanmarie reviewed Jan 6, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

joanmarie requested changes Jan 6, 2020

View reviewed changes

Aaron Leventhal added 3 commits January 14, 2020 11:51

Single change

2a60d43

Add suggestion to roles categorization

f288961

Add semantic sugar and improve wording

89647d4

aleventhal requested a review from joanmarie January 14, 2020 16:59

jnurthen requested review from carmacleod and mcking65 January 23, 2020 18:58

carmacleod reviewed Jan 24, 2020

View reviewed changes

Add example

fd9a55c

carmacleod approved these changes Jan 24, 2020

View reviewed changes

A suggestion must not include children other than the insertion/delet…

d24179d

…ion but may be combined with annotations

carmacleod reviewed Jan 24, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

1871d99

Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>

joanmarie approved these changes Jan 24, 2020

View reviewed changes

mcking65 requested changes Feb 7, 2020

View reviewed changes

aleventhal and others added 3 commits February 7, 2020 09:14

Update index.html

4d145ad

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

Update index.html

8204194

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

Update index.html

ac230b8

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

aleventhal and others added 4 commits February 7, 2020 09:17

Update index.html

96238a4

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

Update index.html

ed3407e

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

Don't use the term author for 2 different things

543f8cb

Post-polish after accepting Matt's suggestions

e544bec

carmacleod reviewed Feb 7, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

6725363

Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>

mcking65 approved these changes Feb 13, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

6e36557

Co-Authored-By: Matt King <a11yThinker@Gmail.com>

jnurthen merged commit 2a047fd into master Feb 13, 2020

carmacleod added a commit that referenced this pull request May 7, 2020

Add suggestion role (#1134)

a2d78e8

* Relates to ARIA Annotations, issue #749 Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com> Co-Authored-By: Matt King <a11yThinker@Gmail.com>

pkra added this to the ARIA 1.3 milestone Jan 10, 2022

pkra mentioned this pull request Jan 10, 2022

FPWD of ARIA 1.3 #1331

Closed

Conversation

aleventhal commented Dec 11, 2019 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joanmarie left a comment

Choose a reason for hiding this comment

Uh oh!

carmacleod left a comment

Choose a reason for hiding this comment

Uh oh!

carmacleod left a comment

Choose a reason for hiding this comment

Uh oh!

joanmarie commented Jan 24, 2020

Uh oh!

aleventhal commented Jan 24, 2020

Uh oh!

Uh oh!

joanmarie left a comment

Choose a reason for hiding this comment

Uh oh!

mcking65 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aleventhal commented Feb 7, 2020

Uh oh!

Uh oh!

mcking65 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aleventhal commented Dec 11, 2019 •

edited by pr-preview bot

Loading