Skip to content

fix(useAsyncQueue): trigger onFinished when the last task is rejected #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(useAsyncQueue): trigger onFinished when the last task is rejected #5144

wants to merge 2 commits into from
+19 −0

Conversation

@keeplearning66
Copy link
Contributor

@keeplearning66 keeplearning66 commented Nov 4, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

fix #5143

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 4, 2025
@keeplearning66 keeplearning66 changed the title fix(useAsyncQueue): should trigger onFinished when the last task is r… fix(useAsyncQueue): should trigger onFinished when the last task is rejected Nov 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 4, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5144

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5144

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5144

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5144

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5144

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5144

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5144

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5144

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5144

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5144

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5144

commit: e3f89d4

@keeplearning66 keeplearning66 changed the title fix(useAsyncQueue): should trigger onFinished when the last task is rejected fix(useAsyncQueue): trigger onFinished when the last task is rejected Nov 4, 2025
@keeplearning66 keeplearning66 mentioned this pull request Nov 4, 2025
Open
7 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OrbisK OrbisK OrbisK approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG | useAsyncQueue | In the last task, reject does not trigger the onFinished event

2 participants

@keeplearning66 @OrbisK