Skip to content

Conversation

@aesyondu
Copy link

@aesyondu aesyondu commented Nov 9, 2020

I copy pasted the original snippet to my babel.config.json.

{
  "babel": {
    "presets": ["@babel/preset-env"]
  }
}

I was wondering why I was getting a weird error: Unknown option: .babel. Check out https://babeljs.io/docs/en/babel-core/#options for more information abou t options.

I spent 10 minutes googling .babel, until I realized that I'm an idiot and the snippet was only applicable to package.json. As someone not yet intimately familiar with babel, I'm hoping this change would help clarify the distinction between package.json and babel.config.json.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Documentation

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This is a documentation update to differentiate package.json from babel.config.json

I copy pasted the original snippet to my `babel.config.json`.
```json
{
  "babel": {
    "presets": ["@babel/preset-env"]
  }
}
```

I was wondering why I was getting a weird error: `Unknown option: .babel. Check out https://babeljs.io/docs/en/babel-core/#options for more information abou
t options.`

I spent 10 minutes googling `.babel`, until I realized that I'm an idiot and the snippet was only applicable to `package.json`. As someone not yet intimately familiar with babel, I'm hoping this change would help clarify the distinction between `package.json` and `babel.config.json`.
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lmiller1990
Copy link
Member

Can you try rebasing and running CI again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants