Skip to content

fix(router): pass the base option as an argument #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haoqunjiang merged 2 commits into from
Apr 16, 2020
Merged

fix(router): pass the base option as an argument #15

haoqunjiang merged 2 commits into from
Apr 16, 2020

Conversation

@posva
Copy link
Member

@posva posva commented Apr 13, 2020

Close #14

posva
posva commented Apr 13, 2020
View reviewed changes
@haoqunjiang haoqunjiang merged commit 82b6dbc into master Apr 16, 2020
@haoqunjiang haoqunjiang deleted the fix/router-codemod branch April 16, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Router: base should be passed to createHistory

3 participants

@posva @haoqunjiang