feat(require-toggle-inside-transition): add additionalDirectives option (#2535) #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynzh
reviewed
Aug 29, 2024
FloEdelmann
requested changes
Aug 29, 2024
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Looks good, apart from the two small open threads.
cjpearson
force-pushed
the
additional-directives-option
branch
from
c9dea58 to
545af71
Compare
FloEdelmann
requested changes
Aug 29, 2024
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Some more small suggestions.
cjpearson
force-pushed
the
additional-directives-option
branch
from
545af71 to
dcd4c73
Compare
FloEdelmann
reviewed
Aug 29, 2024
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
One tiny docs improvement, other than that it looks good to me 🙂
Thanks for your contribution!
FloEdelmann
approved these changes
Aug 29, 2024
cjpearson
force-pushed
the
additional-directives-option
branch
from
3616733 to
d69db95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2535