Skip to content

Allow ESLint v9 as peer dependency #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ota-meshi merged 2 commits into from
Apr 8, 2024
Merged

Allow ESLint v9 as peer dependency #2444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0ae4ed
Allow ESLint v9 as peer dependency
FloEdelmann Apr 8, 2024
00e3727
Remove duplicate test case
FloEdelmann Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,8 @@ jobs:
matrix:
node: [18, 20]
os: [ubuntu-latest]
eslint: [8]
eslint: [8, 9]
include:
# On next ESLint version
- eslint: ^9.0.0-0
node: 20
os: ubuntu-latest
# On old Node version
- eslint: 8
node: 17
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"node": "^14.17.0 || >=16.0.0"
},
"peerDependencies": {
"eslint": "^6.2.0 || ^7.0.0 || ^8.0.0"
"eslint": "^6.2.0 || ^7.0.0 || ^8.0.0 || ^9.0.0"
},
"dependencies": {
"@eslint-community/eslint-utils": "^4.4.0",
Expand Down
31 changes: 0 additions & 31 deletions tests/lib/rules/custom-event-name-casing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,37 +575,6 @@ tester.run('custom-event-name-casing', rule, {
]
},
// kebab-case
{
filename: 'test.vue',
code: `
<template>
<input
@click="$emit('fooBar')">
</template>
<script>
export default {
setup(props, context) {
return {
onInput(value) {
context.emit('barBaz')
}
}
},
methods: {
onClick() {
this.$emit('bazQux')
}
}
}
</script>
`,
options: ['kebab-case'],
errors: [
"Custom event name 'fooBar' must be kebab-case.",
"Custom event name 'barBaz' must be kebab-case.",
"Custom event name 'bazQux' must be kebab-case."
]
},
{
filename: 'test.vue',
code: `
Expand Down