Skip to content

fix(compiler-sfc): error generating CSS sourcemap when using SCSS #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MuTsunTsai wants to merge 4 commits into from
Closed

fix(compiler-sfc): error generating CSS sourcemap when using SCSS #9970

MuTsunTsai wants to merge 4 commits into from

Conversation

@MuTsunTsai
Copy link

@MuTsunTsai MuTsunTsai commented Jan 2, 2024

This is an attempt to fix #9969. See the issue for details.

@yyx990803
Copy link
Member

yyx990803 commented Jan 3, 2024 •
edited
Loading

Looks like I unintentionally introduced this regression in f15d2f6

If this is in fact a Buffer, we should probably just revert the change to always do JSON.parse(result.map.toString()).

@github-actions
Copy link

github-actions bot commented Jan 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.5 kB 34 kB 30.7 kB
vue.global.prod.js 146 kB 53.3 kB 47.6 kB

Usages

Name Size Gzip Brotli
createApp 49.8 kB 19.5 kB 17.8 kB
createSSRApp 53.1 kB 20.8 kB 19 kB
defineCustomElement 52.1 kB 20.3 kB 18.5 kB
overall 63.3 kB 24.4 kB 22.3 kB

@yyx990803 yyx990803 closed this in 71d3121 Jan 3, 2024
@yyx990803
Copy link
Member

yyx990803 commented Jan 3, 2024

Thanks for the PR - for some reason it seems to be including commits that shouldn't belong (maybe because the PR was based off main).

I've reverted SCSS source map handling to the old behavior in 71d3121.

@MuTsunTsai
Copy link
Author

MuTsunTsai commented Jan 3, 2024

Thanks for the PR - for some reason it seems to be including commits that shouldn't belong (maybe because the PR was based off main).

Glad that the issue is resolved. Should I contribute anything else in the future, from which branch should I fork instead?

@yyx990803
Copy link
Member

yyx990803 commented Jan 4, 2024

It's best to check out a new branch in your fork and work in that branch, so you can sync your main branch periodically with the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error generating CSS sourcemap when using SCSS

2 participants

@MuTsunTsai @yyx990803