Skip to content

fix(hydration): should force hydrate props with .prop & .attr modifiers #7490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edison1105 wants to merge 7 commits into from
Closed

fix(hydration): should force hydrate props with .prop & .attr modifiers #7490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
53fe2d7
fix(hydration): should force hydrate props with .prop & ^attr modifiers
edison1105 Jan 10, 2023
56d7309
fix: test case
edison1105 Jan 10, 2023
ca14802
fix: test case
edison1105 Jan 10, 2023
72fb005
fix: test case
edison1105 Jan 10, 2023
b8f750c
Merge branch 'vuejs:main' into fix/7476
edison1105 Feb 23, 2023
9bf32c0
Merge branch 'vuejs:main' into fix/7476
edison1105 Mar 28, 2023
b328908
Merge branch 'main' into fix/7476
edison1105 Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/runtime-core/__tests__/hydration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,30 @@ describe('SSR hydration', () => {
expect((container.firstChild!.firstChild as any)._value).toBe(true)
})

test('force hydrate prop with `.prop` modifier', () => {
const { container } = mountWithHydration(
'<input type="checkbox" :indeterminate.prop="true">',
() =>
h('input', {
type: 'checkbox',
'.indeterminate': true
})
)
expect((container.firstChild! as any).indeterminate).toBe(true)
})

test('force hydrate prop with `.attr` modifier', () => {
const { container } = mountWithHydration(
'<input type="checkbox" :x.attr="1">',
() =>
h('input', {
type: 'checkbox',
'^x': 1
})
)
expect((container.firstChild! as any).getAttribute('x')).toBe('1')
})

// #5728
test('empty text node in slot', () => {
const Comp = {
Expand Down
5 changes: 4 additions & 1 deletion packages/runtime-core/src/hydration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,10 @@ export function createHydrationFunctions(
for (const key in props) {
if (
(forcePatchValue && key.endsWith('value')) ||
(isOn(key) && !isReservedProp(key))
(isOn(key) && !isReservedProp(key)) ||
// support .prop & .attr modifiers
key[0] === '.' ||
key[0] === '^'
) {
patchProp(
el,
Expand Down