Fix alpha test for standard PBR shader#321
Merged
robertosfield merged 1 commit intovsg-dev:masterfrom Oct 15, 2024
Merged
Conversation
It looks like the existing line was copied and pasted from the Phong shader, but the variables don't match. Phong's `material`'s equivalent is called `pbr` in the PBR shader, and while `diffuseColor` is a real variable in the PBR shader, it's not been initialised when this line runs, so `baseColor` should be used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the existing line was copied and pasted from the Phong shader, but the variables don't match. Phong's
material's equivalent is calledpbrin the PBR shader, and whilediffuseColoris a real variable in the PBR shader, it's not been initialised when this line runs, sobaseColorshould be used instead.