Constant row-encode kernel#8005
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Conversation
Replace the stub `RowSizeKernel` / `RowEncodeKernel` impls for `ConstantArray` with real implementations that skip canonicalization. The size pass adds the (constant) per-row scalar size to every entry of the shared `sizes` slice. The encode pass encodes the scalar bytes once into a small heap buffer, then `copy_nonoverlapping`s those bytes into each row's slot. Per-row work is one `copy_nonoverlapping(N)` plus one cursor add, where `N` is typically 9 (i64), 5 (i32), or 17 (i128). Add a `constant_i64_*` bench triplet (arrow-row baseline, vortex with kernel, vortex through canonicalization) and a `constant_path_matches_canonical` test that round-trips bytes both ways and asserts they're identical. Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
Merging this PR will improve performance by 14.26%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | new_alp_prim_test_between[f32, 16384] |
118.3 µs | 103.8 µs | +13.96% |
| ⚡ | Simulation | new_bp_prim_test_between[i16, 32768] |
132.2 µs | 120.1 µs | +10.13% |
| ⚡ | Simulation | new_alp_prim_test_between[f32, 32768] |
182.1 µs | 153.2 µs | +18.85% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/row-c20-constant-kernel (17eb2ca) with claude/row-c19-inventory-registry (c0b24ad)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 20 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
Replaces the stub
RowSizeKernel/RowEncodeKernelimpls forConstantArraywith real implementations that skip canonicalization.The size pass adds the (constant) per-row scalar size to every entry of the shared
sizesslice. The encode pass encodes the scalar bytes once into a small heap buffer, thencopy_nonoverlappings those bytes into each row's slot. Per-row work is onecopy_nonoverlapping(N)plus one cursor add, whereNis typically 9 (i64), 5 (i32), or 17 (i128).Adds a
constant_i64_*bench triplet (arrow-row baseline, vortex with kernel, vortex through canonicalization) and aconstant_path_matches_canonicaltest that round-trips bytes both ways and asserts they're identical.Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #8004 (
claude/row-c19-inventory-registry)Next in stack: #8006 (
claude/row-c21-dict-kernel)Combined context
For the full design + rationale, see PR #7985 (top of stack).