Skip to content

feat: teach ArrayStream instrument(span)#7741

Open
danking wants to merge 2 commits into
developfrom
dk/instrumented-array-stream
Open

feat: teach ArrayStream instrument(span)#7741
danking wants to merge 2 commits into
developfrom
dk/instrumented-array-stream

Conversation

@danking
Copy link
Copy Markdown
Contributor

@danking danking commented Apr 30, 2026

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026 •
edited
Loading

Merging this PR will degrade performance by 38.78%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 1192 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime mix[50%_in/50%_out] 340 µs 395.3 µs -13.99%
❌ WallTime for[10M_u8] 75.4 µs 123.2 µs -38.78%
❌ WallTime for[10M_u16] 95.6 µs 151.6 µs -36.95%
❌ WallTime mix[100%_in/0%_out] 452.6 µs 505.9 µs -10.53%
⚡ WallTime runend[10M_i32_runlen_100000] 130 µs 91.1 µs +42.7%
⚡ WallTime 10M_50%[5000000] 192.3 µs 153.4 µs +25.35%

Comparing dk/instrumented-array-stream (bc3b8f5) with develop (deb7de0)

Open in CodSpeed

@danking
feat: teach ArrayStream instrument(span)
f9768d5 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking force-pushed the dk/instrumented-array-stream branch from 91c0434 to f9768d5 Compare April 30, 2026 19:51
@danking danking marked this pull request as ready for review April 30, 2026 19:52
@danking danking enabled auto-merge (squash) April 30, 2026 19:52
a10y
a10y reviewed Apr 30, 2026
View reviewed changes
Comment thread vortex-array/src/stream/instrumented.rs Outdated
@danking
imports
bc3b8f5 
Signed-off-by: Daniel King <dan@spiraldb.com>
@a10y
Copy link
Copy Markdown
Contributor

a10y commented Apr 30, 2026

you might need the ol' ./scripts/public-api.sh

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label May 16, 2026
@danking danking added changelog/feature A new feature and removed stale This PR is stale and will be auto-closed soon labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a10y a10y a10y approved these changes

@robert3005 robert3005 robert3005 approved these changes

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danking @a10y @robert3005