Write registry values directly to avoid Path environment variable truncation.#1931
Open
hamflx wants to merge 1 commit intovolta-cli:mainfrom
Open
Write registry values directly to avoid Path environment variable truncation.#1931hamflx wants to merge 1 commit intovolta-cli:mainfrom
hamflx wants to merge 1 commit intovolta-cli:mainfrom
Conversation
Classicrichblog
approved these changes
Nov 29, 2024
Author
|
@Classicrichblog Friendly ping on this, let me know if it needs a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform: Windows
the problem:
setx will truncate the path to 1024 characters. see https://superuser.com/a/387625
This PR directly uses writing registry values instead of spawning the
setxcommand.