Conversation
Contributor
|
You may also wish to have a look at #56828. |
Contributor
Author
that's actually what I need it for 😅 |
Contributor
|
You mean you want to package kaidan?
|
Contributor
Author
Yeah, sry about the force push mess. I'm still tweaking the template |
Contributor
|
Duplicate PRs are generally frowned upon, you should have expressed your
interest at the existing one, I could have given you write access or
something.
It's too late now though I suppose, so I will just close mine when yours
is ready.
In any case, I am happy to see interest in kaidan :-)
|
Contributor
Author
Again, sorry. I messed up, when I searched for related Issues/PRs #56828 did show up but it was "Stale". But this library is already in the repos so I thought updating it in a separate PR made sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing