Conversation
|
The PyArg_ParseTuple() need some tweaking:
|
56b00b1 to
bf1e2db
Compare
|
Thanks @arigo, I appreciate it. I've amended the change to try to address these issues. The first is an obvious blunder, and I've updated to initialize the variable. The second is a bit more intricate as you note. I've updated to safely cast to Apologies if this is different than what you had in mind. I also consulted with the standard library implementation of |
|
Looks good to me. I'm not really contributing to vmprof, but I don't know if anyone is at the moment, so I'll go ahead and merge your pull request. Sorry if I'm stepping on someone else's toes. |
|
Thanks @timpalpant - this actually makes real-time profiling more useful for my use case, too, and I appreciate your in-depth diagnosis of EINTR being the original culprit for tests failing. Out of curiosity - do you happen to be using the real-time stuff as well, or was it a more preemptive fix? (I'm trying to gauge interest because actually documenting the real-time capabilities was on my list since forever, but I vaguely assumed this is a niche application, so I never got around to it.) |
This allows the user to register another thread for real time profiling by passing its identity (thread id), rather than needing to call
insert_real_time_thread()from within each thread.Fixes #201. Depends on / includes #204 to fix the real_time_threaded test.