Closed
Conversation
This was referenced Aug 7, 2019
Contributor
Author
|
At least one of the test flakes is due to #191. |
Contributor
Author
|
This PR was subsumed into #205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On CPython < 3.5, system calls may be interrupted with EINTR when a signal is received (see PEP-475). In particular,
sleepis not retried after SIGALRM, even if requested withSA_RESTART(see:signal(7)).This updates and re-enables the
test_vmprof_real_timetest by retrying (if necessary) until the requested time has elapsed. A proper solution for #159 on Python 2 would require a more significant update to not useSIGALRM, and having the tests re-enabled first seemed like a good start.Ref #159 and #202.