Skip to content

[Refactor] Simplify dummy data generation - #35025

Merged
vllm-bot merged 12 commits into
vllm-project:mainfrom
DarkLight1337:simplify-dummy-data
Feb 23, 2026
Merged

[Refactor] Simplify dummy data generation#35025
vllm-bot merged 12 commits into
vllm-project:mainfrom
DarkLight1337:simplify-dummy-data

Conversation

@DarkLight1337

@DarkLight1337 DarkLight1337 commented Feb 21, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Purpose

Test Plan

Using the same test as #34330

Test Result

(Worker_TP2 pid=1233399) INFO 02-21 15:00:08 [gpu_model_runner.py:5150] Encoder cache will be initialized with a budget of 114688 tokens, and profiled with 1 video items of the maximum feature size.
(Worker_TP3 pid=1233400) INFO 02-21 15:00:08 [gpu_model_runner.py:5150] Encoder cache will be initialized with a budget of 114688 tokens, and profiled with 1 video items of the maximum feature size.
(Worker_TP1 pid=1233398) INFO 02-21 15:00:08 [gpu_model_runner.py:5150] Encoder cache will be initialized with a budget of 114688 tokens, and profiled with 1 video items of the maximum feature size.
(Worker_TP0 pid=1233397) INFO 02-21 15:00:08 [gpu_model_runner.py:5150] Encoder cache will be initialized with a budget of 114688 tokens, and profiled with 1 video items of the maximum feature size.
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337
[Refactor] Simplify dummy data generation
35a5556 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2026
@dosubot

dosubot Bot commented Feb 21, 2026

Copy link
Copy Markdown

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@mergify

mergify Bot commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--35025.org.readthedocs.build/en/35025/

@mergify mergify Bot added documentation Improvements or additions to documentation deepseek Related to DeepSeek models llama Related to Llama models multi-modality Related to multi-modality (#4194) qwen Related to Qwen models speculative-decoding labels Feb 21, 2026
@DarkLight1337
Fix
9555e29 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the dummy data generation for multimodal models by centralizing the merging of keyword arguments from the multimodal configuration. This simplifies the get_dummy_mm_data and get_hf_processor methods across numerous model implementations. While the refactor is comprehensive, there are a few inconsistencies in the updated method signatures and missing keyword argument support in some custom processor adapters that could lead to runtime errors.

Comment thread vllm/model_executor/models/kimi_vl.py
Comment thread vllm/model_executor/models/transformers/multimodal.py
Comment thread vllm/model_executor/models/isaac.py
@DarkLight1337
Fix
c554242 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
7a66ffd 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
5bcf7b0 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
eb2dd45 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
08861bc 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
1e4bbd6 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) February 21, 2026 17:17
@DarkLight1337
Merge branch 'main' into simplify-dummy-data
d8b343e
@DarkLight1337
Update
8de43a6 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
ada60f7 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix tests
fe66499 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@vllm-bot
vllm-bot merged commit 987506b into vllm-project:main Feb 23, 2026
58 of 61 checks passed
@DarkLight1337
DarkLight1337 deleted the simplify-dummy-data branch February 23, 2026 04:56
jmamou pushed a commit to jmamou/vllm that referenced this pull request Feb 23, 2026
@DarkLight1337 @jmamou
[Refactor] Simplify dummy data generation (vllm-project#35025)
9252b68 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@TheCodeWrangler TheCodeWrangler mentioned this pull request Feb 26, 2026
Merged
@iboiko-habana iboiko-habana mentioned this pull request Mar 6, 2026
Merged
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
@DarkLight1337
[Refactor] Simplify dummy data generation (vllm-project#35025)
60cde31 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
jiangkuaixue123 pushed a commit to jiangkuaixue123/vllm that referenced this pull request Apr 28, 2026
@DarkLight1337 @jiangkuaixue123
[Refactor] Simplify dummy data generation (vllm-project#35025)
e6ac59a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
@DarkLight1337
[Refactor] Simplify dummy data generation (vllm-project#35025)
12f308e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@DarkLight1337
[Refactor] Simplify dummy data generation (vllm-project#35025)
6dbc707 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@DarkLight1337
[Refactor] Simplify dummy data generation (vllm-project#35025)
b6d5f9b 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes
@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten patrickvonplaten is a code owner
@sighingnow sighingnow Awaiting requested review from sighingnow
@hmellor hmellor Awaiting requested review from hmellor hmellor is a code owner
@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner
@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner
@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner
@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner
@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner
@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner
@houseroad houseroad Awaiting requested review from houseroad houseroad is a code owner
@yewentao256 yewentao256 Awaiting requested review from yewentao256 yewentao256 is a code owner
@ProExpertProg ProExpertProg Awaiting requested review from ProExpertProg ProExpertProg is a code owner
@NickLucche NickLucche Awaiting requested review from NickLucche NickLucche is a code owner
@tjtanaa tjtanaa Awaiting requested review from tjtanaa tjtanaa is a code owner
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deepseek Related to DeepSeek models documentation Improvements or additions to documentation llama Related to Llama models multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @Isotr0py @vllm-bot