Move LoRAConfig from config/__init__.py to config/lora.py
#24644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmellor
requested review from
ProExpertProg,
WoosukKwon,
alexm-redhat,
comaniac,
houseroad,
jeejeelee,
mgoin,
njhill,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256,
youkaichao,
ywang96 and
zhuohan123
as code owners
hmellor
changed the title
LoadConfig from config/__init__.py to config/lora.pyLoRAConfig from config/__init__.py to config/lora.py
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
force-pushed
the
extract-lora-config
branch
from
8815183 to
305b1a4
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the location of LoRAConfig, moving it from the main vllm/config/__init__.py file into its own dedicated module, vllm/config/lora.py. This is a good code organization improvement. The changes include moving the class and updating all internal import paths accordingly. Backward compatibility is maintained by re-exporting LoRAConfig from the original location. The changes are straightforward and have been implemented correctly. I found no high or critical issues in this pull request.
DarkLight1337
approved these changes
Sep 11, 2025
DarkLight1337
added
the
ready
jeejeelee
approved these changes
Sep 11, 2025
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…-project#24644) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
…-project#24644) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…-project#24644) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…-project#24644) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…-project#24644) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18953