[Bugfix] Fix _synced_weight_loader #24565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in _synced_weight_loader where the return value from the wrapped original_weight_loader was being discarded. The change correctly captures this return value and returns it after the synchronization logic. This is a critical fix as callers, especially in TPU environments where this wrapper is used, may rely on the weight loader's return value, and were previously receiving None. The fix is correct and well-isolated.
kyuyeunk
force-pushed
the
fix_synced_weight_loader
branch
from
465f329 to
f0efeeb
Compare
kyuyeunk
force-pushed
the
fix_synced_weight_loader
branch
4 times, most recently
from
916bb80 to
edbab1b
Compare
Fixes a bug when the vLLM expects weight loader to return output when using return_success=True Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
kyuyeunk
force-pushed
the
fix_synced_weight_loader
branch
from
edbab1b to
af0ca8a
Compare
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when the vLLM expects weight loader to return output when using return_success=True
Purpose
Fixes a bug when the vLLM expects weight loader to return output when using
return_success=TrueExample: qwen3_moe.py