[Engine][Chore] use local variable and remove output var assignment #24554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two minor refactorings in the beam_search method. It caches tokenizer.eos_token_id in a local variable and removes an unnecessary intermediate variable for the RequestOutput. These changes improve code clarity and are functionally correct. I've added one suggestion to handle cases where a tokenizer might not have an EOS token defined, which would prevent incorrect behavior during beam search.
Signed-off-by: Guy Stone <guys@spotify.com>
GuyStone
force-pushed
the
beam-chore
branch
from
6601b73 to
e2abadb
Compare
njhill
approved these changes
Sep 10, 2025
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…llm-project#24554) Signed-off-by: Guy Stone <guys@spotify.com>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
…llm-project#24554) Signed-off-by: Guy Stone <guys@spotify.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…llm-project#24554) Signed-off-by: Guy Stone <guys@spotify.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…llm-project#24554) Signed-off-by: Guy Stone <guys@spotify.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…llm-project#24554) Signed-off-by: Guy Stone <guys@spotify.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.