[CI] Adjust threshold for flaky ngram spec decoding test #24528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <nhill@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adjusts the threshold for a flaky test in test_spec_decode.py. The change lowers the required match rate and also corrects a logical inconsistency in the assertion. My review includes a suggestion to make the assertion more robust by avoiding integer truncation, which could lead to incorrect test behavior if the number of test cases changes in the future. This will improve the long-term stability and correctness of the test.
ekagra-ranjan
approved these changes
Sep 9, 2025
wwl2755
approved these changes
Sep 9, 2025
simon-mo
approved these changes
Sep 10, 2025
DarkLight1337
added a commit
to DarkLight1337/vllm
that referenced
this pull request
Sep 12, 2025
…ect#24528 Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
5 tasks
This was referenced Sep 12, 2025
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…t#24528) Signed-off-by: Nick Hill <nhill@redhat.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…t#24528) Signed-off-by: Nick Hill <nhill@redhat.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…t#24528) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…t#24528) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failure: https://buildkite.com/vllm/ci/builds/29986#01992f4f-eb2f-49b5-a31f-9e6ead3a010e
Fixes #24314