Skip to content

[CI/Build] split true unit tests to Entrypoints Unit Tests #24418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vllm-bot merged 4 commits into from
Sep 10, 2025
Merged

[CI/Build] split true unit tests to Entrypoints Unit Tests #24418

vllm-bot merged 4 commits into from
Sep 10, 2025

Conversation

@yeqcharlotte
Copy link
Collaborator

@yeqcharlotte yeqcharlotte commented Sep 8, 2025 •
edited by github-actions bot
Loading

Purpose

Noticed unit tests in #24285 are not triggered. So were some other entrypoint unit tests not in llm/ or openai/ directories.

Given entry point tests fail so often, moving true unit tests (that does not download models, use mocks, does not start a server) to a dedicated label so at least we can see them in a separate tab. This possibly require further refactoring following #22992

Test Plan

Run the following tests manually

pytest -v -s entrypoints/openai/tool_parsers
pytest -v -s entrypoints/ --ignore=entrypoints/llm --ignore=entrypoints/openai --ignore=entrypoints/offline_mode --ignore=entrypoints/test_chat_utils.py

Test Result

================================================================================================================= warnings summary ==================================================================================================================
../../../../../../home/yeq/uv_env/vllm/lib64/python3.12/site-packages/schemathesis/generation/coverage.py:305
  /home/yeq/uv_env/vllm/lib64/python3.12/site-packages/schemathesis/generation/coverage.py:305: DeprecationWarning: jsonschema.exceptions.RefResolutionError is deprecated as of version 4.18.0. If you wish to catch potential reference resolution
errors, directly catch referencing.exceptions.Unresolvable.
    ref_error: type[Exception] = jsonschema.RefResolutionError,

tests/entrypoints/test_ssl_cert_refresher.py::test_ssl_refresher
  /data/users/yeq/gitrepos/vllm/tests/entrypoints/test_ssl_cert_refresher.py:47: DeprecationWarning: ssl.SSLContext() without protocol argument is deprecated.
    ssl_context = MockSSLContext()

tests/entrypoints/test_ssl_cert_refresher.py::test_ssl_refresher
  /data/users/yeq/gitrepos/vllm/tests/entrypoints/test_ssl_cert_refresher.py:47: DeprecationWarning: ssl.PROTOCOL_TLS is deprecated
    ssl_context = MockSSLContext()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================================================== 25 passed, 3 warnings in 16.38s ==========================================================================================================

================================================================================================================= warnings summary ==================================================================================================================
../../../../../../home/yeq/uv_env/vllm/lib64/python3.12/site-packages/schemathesis/generation/coverage.py:305
  /home/yeq/uv_env/vllm/lib64/python3.12/site-packages/schemathesis/generation/coverage.py:305: DeprecationWarning: jsonschema.exceptions.RefResolutionError is deprecated as of version 4.18.0. If you wish to catch potential reference resolution errors, directly catch referencing.exceptions.Unresolvable.
    ref_error: type[Exception] = jsonschema.RefResolutionError,

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================================================ 59 passed, 1 xfailed, 1 warning in 96.79s (0:01:36) ================================================================================================

in buildkite
image

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Sep 8, 2025
@yeqcharlotte
split true unit tests to Entrypoints Unit Tests
3c7a6c7 
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
@yeqcharlotte
fix test_api_server_process_manager.py
1fd7d92 
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
@yeqcharlotte yeqcharlotte force-pushed the entrypoint_test_splits branch from 1a183aa to 1fd7d92 Compare September 9, 2025 08:56
@yeqcharlotte yeqcharlotte marked this pull request as ready for review September 9, 2025 08:56
@yeqcharlotte yeqcharlotte added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2025
@yeqcharlotte
fix
f37bd89 
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
njhill
njhill approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yeqcharlotte

@vllm-bot vllm-bot merged commit 492196e into vllm-project:main Sep 10, 2025
68 of 72 checks passed
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
@yeqcharlotte @skyloevil
[CI/Build] split true unit tests to Entrypoints Unit Tests (vllm-proj…
6fad99d 
…ect#24418)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@yeqcharlotte @FeiDaLI
[CI/Build] split true unit tests to Entrypoints Unit Tests (vllm-proj…
3b658d2 
…ect#24418)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@yeqcharlotte @xuebwang-amd
[CI/Build] split true unit tests to Entrypoints Unit Tests (vllm-proj…
96b326a 
…ect#24418)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@yeqcharlotte @xuebwang-amd
[CI/Build] split true unit tests to Entrypoints Unit Tests (vllm-proj…
104e819 
…ect#24418)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yeqcharlotte @njhill @vllm-bot