Skip to content

[Bugfix] Fix silu_mul+quant fusion test #24341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ProExpertProg merged 1 commit into from
Sep 5, 2025
Merged

[Bugfix] Fix silu_mul+quant fusion test #24341

ProExpertProg merged 1 commit into from
Sep 5, 2025

Conversation

@elvischenv
Copy link
Contributor

@elvischenv elvischenv commented Sep 5, 2025 •
edited by github-actions bot
Loading

Purpose

#23725 broke the silu_mul + quant unit test, we have to use named arguments here.

>       model = model_class(hidden_size, cuda_force_torch)
E       TypeError: TestSiluMulNvfp4QuantModel.__init__() takes 2 positional arguments but 3 were given
tests/compile/test_silu_mul_quant_fusion.py:121: TypeError

Test Plan && Test Result

tests/compile/test_silu_mul_quant_fusion.py

======= 3 passed, 1 skipped, 5 warnings in 3.94s ====
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@elvischenv
fix silu+quant fusion test
82ba0f1 
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a TypeError in the silu_mul+quant fusion test. The fix involves changing the model instantiation from positional arguments to keyword arguments. This is a correct and robust solution that resolves the bug for all parameterized model classes within the test. The change is well-contained and improves the code's clarity.

@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 5, 2025
@ProExpertProg ProExpertProg enabled auto-merge (squash) September 5, 2025 19:50
@ProExpertProg ProExpertProg merged commit eedb2a2 into vllm-project:main Sep 5, 2025
27 of 29 checks passed
@elvischenv elvischenv deleted the elvischenv/fix-silu-mul-quant-fusion-test branch September 6, 2025 10:22
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
@elvischenv @eicherseiji
[Bugfix] Fix silu_mul+quant fusion test (vllm-project#24341)
88a9a80 
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
@elvischenv @skyloevil
[Bugfix] Fix silu_mul+quant fusion test (vllm-project#24341)
a2bd5a5 
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@elvischenv @FeiDaLI
[Bugfix] Fix silu_mul+quant fusion test (vllm-project#24341)
41a4306 
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@elvischenv @xuebwang-amd
[Bugfix] Fix silu_mul+quant fusion test (vllm-project#24341)
5e53939 
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@elvischenv @xuebwang-amd
[Bugfix] Fix silu_mul+quant fusion test (vllm-project#24341)
10544d9 
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ProExpertProg ProExpertProg ProExpertProg approved these changes

@simon-mo simon-mo simon-mo approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elvischenv @ProExpertProg @simon-mo