Skip to content

Conversation

@cjackal
Copy link
Contributor

@cjackal cjackal commented Sep 5, 2025

Purpose

Update documentation for vllm serve CLI arguments. Especially,

Test Plan

N/A

Test Result

N/A


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
@cjackal cjackal requested a review from aarnphm as a code owner September 5, 2025 15:32
@mergify mergify bot added the frontend label Sep 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for vllm serve CLI arguments. It removes an outdated performance warning for --enable-request-id-headers and corrects the swapped docstrings for --enable-auto-tool-choice and --exclude-tools-when-tool-choice-none. The changes are accurate and improve documentation clarity. The PR looks good.

@russellb russellb enabled auto-merge (squash) September 9, 2025 01:19
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2025
@russellb russellb merged commit 13b89bd into vllm-project:main Sep 9, 2025
48 checks passed
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
@cjackal cjackal deleted the fix-docs branch September 14, 2025 09:48
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: cjackal <44624812+cjackal@users.noreply.github.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants