Skip to content

fix some typos #24167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vllm-bot merged 4 commits into from
Sep 10, 2025
Merged

fix some typos #24167

vllm-bot merged 4 commits into from
Sep 10, 2025

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Sep 3, 2025 •
edited by github-actions bot
Loading

Purpose

fix some typos

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@co63oc
fix some typos
fb5f5a8 
Signed-off-by: co63oc <co63oc@users.noreply.github.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses several minor typographical errors in comments, docstrings, and test messages. The changes are correct and improve readability without affecting any logic. The pull request is good to merge.

@russellb russellb enabled auto-merge (squash) September 4, 2025 03:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 4, 2025
@vllm-bot vllm-bot merged commit 3144d90 into vllm-project:main Sep 10, 2025
37 of 39 checks passed
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
@co63oc @russellb @skyloevil
fix some typos (vllm-project#24167)
2a1a0c2 
Signed-off-by: co63oc <co63oc@users.noreply.github.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@co63oc @russellb @FeiDaLI
fix some typos (vllm-project#24167)
d775e67 
Signed-off-by: co63oc <co63oc@users.noreply.github.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@co63oc @russellb @xuebwang-amd
fix some typos (vllm-project#24167)
3b2f73b 
Signed-off-by: co63oc <co63oc@users.noreply.github.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@co63oc @russellb @xuebwang-amd
fix some typos (vllm-project#24167)
314d399 
Signed-off-by: co63oc <co63oc@users.noreply.github.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed tool-calling v1

Projects

Tool Calling
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@co63oc @russellb @vllm-bot