[docs][misc] IOProcessor plugins fixes #24046
Conversation
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements. It fixes broken links in the documentation, which enhances usability. A critical correctness issue is addressed in post_process_async by sorting model outputs, ensuring that they are processed in the correct order. The PR also adds a new feature to disable softmax in pooling parameters for encode tasks, providing more control over the raw model output. This new feature is accompanied by corresponding updates in an example and tests. Additionally, the prithvi_io_processor plugin is simplified by removing redundant async method overrides, relying on the improved base class implementation. Overall, the changes are well-implemented and improve the robustness and functionality of IOProcessor plugins.
github-actions
bot
added
the
ready
maxdebayser
left a comment
maxdebayser
left a comment
There was a problem hiding this comment.
Thanks, I didn't think about the ordering issue.
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
3 participants
This is a quick follow-up PR to #22820.
Fixes:
post_process_asyncbefore invokingpost_processin default interface implementationsoftmax=Falsein pooling params for encode with plugins to get the full model raw output.@DarkLight1337 @maxdebayser