Skip to content

Conversation

@didier-durand
Copy link
Contributor

@didier-durand didier-durand commented Sep 1, 2025

Purpose

Improve code documentation quality by fixing typos

Test Plan

N/A

Test Result

N/A

Signed-off-by: Didier Durand <durand.didier@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consists of a series of minor but helpful typo and grammar corrections within comments and docstrings across various files. These changes enhance the clarity and professionalism of the codebase's documentation. All the modifications are accurate and beneficial. I have reviewed the changes and found no issues; the pull request is ready to be merged.

@mergify
Copy link

mergify bot commented Sep 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @didier-durand.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 1, 2025
didier-durand and others added 6 commits September 1, 2025 08:25
…tialization (vllm-project#23357)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Didier Durand <durand.didier@gmail.com>
# Conflicts:
#	vllm/model_executor/models/ovis2_5.py
Signed-off-by: Benji Beck <benjibeck@meta.com>
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Co-authored-by: Max de Bayser <mbayser@br.ibm.com>
…LAM Tool Parser (vllm-project#22769)

Signed-off-by: Devon Peroutky <devon@kindo.ai>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
@mergify mergify bot added ci/build llama Related to Llama models multi-modality Related to multi-modality (#4194) labels Sep 1, 2025
@mergify mergify bot removed the needs-rebase label Sep 1, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 1, 2025 06:28
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 1, 2025 06:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 1, 2025
@DarkLight1337 DarkLight1337 merged commit 1072849 into vllm-project:main Sep 1, 2025
59 checks passed
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
Signed-off-by: Didier Durand <durand.didier@gmail.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Didier Durand <durand.didier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation frontend llama Related to Llama models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding tool-calling tpu Related to Google TPUs v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants