Skip to content

[CI Failure] Skip failing nvfp4 silu test #23959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yewentao256 merged 3 commits into from
Sep 2, 2025
Merged

[CI Failure] Skip failing nvfp4 silu test #23959

yewentao256 merged 3 commits into from
Sep 2, 2025

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Aug 29, 2025 •
edited by github-actions bot
Loading

Purpose

It seems the Blackwell Test is failing on main since #23929, so skipping if the symbol isn't found for now

Log: https://buildkite.com/vllm/ci/builds/28870/steps/canvas?sid=0198f6b1-3529-46d8-9896-06aac42648d6

FAILED tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py::test_quantize_to_fp4[cuda:0-42-shape0-dtype0] - AttributeError: '_OpNamespace' '_C' object has no attribute 'silu_and_mul_nvfp4_quant'

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mgoin
Skip failing nvfp4 silu test
6650aea 
Signed-off-by: mgoin <mgoin64@gmail.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pragmatic fix for a CI failure in the nvfp4 SILU test. By checking for the existence of the silu_and_mul_nvfp4_quant operator before running the test, it ensures that the test suite doesn't fail in environments where this custom operator isn't compiled. My review includes a suggestion to update the test skip reason to accurately reflect this new condition, which will improve maintainability.

@mgoin mgoin added the ci-failure Issue about an unexpected test failure in CI label Aug 29, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Aug 30, 2025 •
edited
Loading

Maybe fixed by #23973, let's see https://buildkite.com/vllm/ci/builds/28921/steps/canvas?jid=0198f9d4-fc6b-4e72-89a5-08aa3fac4cd9

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 30, 2025
@njhill
Copy link
Member

njhill commented Sep 2, 2025

It appears this wasn't fixed by #23973 and it's still impacting CI. So we should probably merge this?

yewentao256
yewentao256 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should land this first, still PR failing like #23289

@yewentao256 yewentao256 merged commit e66ed3e into vllm-project:main Sep 2, 2025
17 checks passed
@njhill njhill deleted the patch-mxfp4-silu branch September 2, 2025 17:31
@ProExpertProg ProExpertProg mentioned this pull request Sep 2, 2025
Merged
5 tasks
@MatthewBonanni MatthewBonanni mentioned this pull request Sep 2, 2025
Merged
5 tasks
elvischenv added a commit to elvischenv/vllm that referenced this pull request Sep 3, 2025
@elvischenv
Revert "[CI Failure] Skip failing nvfp4 silu test (vllm-project#23959)"
8a1b505 
This reverts commit e66ed3e.

Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
@mgoin @yewentao256 @eicherseiji
[CI Failure] Skip failing nvfp4 silu test (vllm-project#23959)
c8ce9f5 
Signed-off-by: mgoin <mgoin64@gmail.com>
Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@mgoin @yewentao256 @FeiDaLI
[CI Failure] Skip failing nvfp4 silu test (vllm-project#23959)
019e4c7 
Signed-off-by: mgoin <mgoin64@gmail.com>
Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill approved these changes

@yewentao256 yewentao256 yewentao256 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed

Projects

CI Failures
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgoin @DarkLight1337 @njhill @yewentao256