[UT] fix unify_kv_cache_configs when kv cache config needs sort #23843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyxning
force-pushed
the
fix_unify_kv_cache_configs_when_kv_cache_config_needs_sort
branch
from
81b86f9 to
3362ecd
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates a unit test for unify_kv_cache_configs to correctly verify the sorting behavior of kv_cache_groups. The previous implementation only asserted the unification of num_blocks, but this change adds assertions to ensure the kv_cache_groups are sorted as expected, improving the test's correctness and coverage. The change is accurate and enhances the test suite.
andyxning
force-pushed
the
fix_unify_kv_cache_configs_when_kv_cache_config_needs_sort
branch
2 times, most recently
from
ccc3c17 to
2cf7bb1
Compare
Signed-off-by: Andy Xie <andy.xning@gmail.com>
andyxning
force-pushed
the
fix_unify_kv_cache_configs_when_kv_cache_config_needs_sort
branch
from
2cf7bb1 to
9bcc7c9
Compare
hmellor
reviewed
Aug 29, 2025
Member
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
Just a nit about naming so it's clearer what it is that's wanted
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Michael Goin <mgoin64@gmail.com>
mgoin
approved these changes
Aug 30, 2025
github-actions
bot
added
the
ready
andyxning
deleted the
fix_unify_kv_cache_configs_when_kv_cache_config_needs_sort
branch
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When
kv_cache_configsneeds sort, the result should check for the sortedkv_cache_configsinstead ofnum_blocks.Test Plan
NA
Test Result
NA
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.