Skip to content

Conversation

@jeanschmidt
Copy link
Contributor

@jeanschmidt jeanschmidt commented Aug 28, 2025

Purpose

Adds the file .github/scale_config.yml with the definition of the runners meta will be providing for Github Actions.

Test Plan

N/A

Test Result

N/A

Signed-off-by: Jean Schmidt <contato@jschmidt.me>
@mergify mergify bot added the ci/build label Aug 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration file, .github/scale-config.yml, to define available runner types for GitHub Actions autoscaling. The change itself is straightforward, adding a linux.2xlarge runner type. However, I have a critical concern regarding the process that needs to be followed when modifying this file, as documented within the file's comments. It's crucial to ensure the validation script is run and dependent changes in other repositories are merged first to prevent breaking the CI infrastructure. Please see my detailed comment.

Signed-off-by: Jean Schmidt <contato@jschmidt.me>
@jeanschmidt
Copy link
Contributor Author

Code Review

This pull request introduces a new configuration file, .github/scale-config.yml, to define available runner types for GitHub Actions autoscaling. The change itself is straightforward, adding a linux.2xlarge runner type. However, I have a critical concern regarding the process that needs to be followed when modifying this file, as documented within the file's comments. It's crucial to ensure the validation script is run and dependent changes in other repositories are merged first to prevent breaking the CI infrastructure. Please see my detailed comment.

removed the unnecessary comments that came from copying this file from another project.

@simon-mo simon-mo merged commit 8805ad9 into vllm-project:main Aug 28, 2025
7 of 12 checks passed
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants