-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Add scale_config.yml file for Meta autoscalers for GH Actions #23840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jean Schmidt <contato@jschmidt.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new configuration file, .github/scale-config.yml, to define available runner types for GitHub Actions autoscaling. The change itself is straightforward, adding a linux.2xlarge runner type. However, I have a critical concern regarding the process that needs to be followed when modifying this file, as documented within the file's comments. It's crucial to ensure the validation script is run and dependent changes in other repositories are merged first to prevent breaking the CI infrastructure. Please see my detailed comment.
Signed-off-by: Jean Schmidt <contato@jschmidt.me>
removed the unnecessary comments that came from copying this file from another project. |
…roject#23840) Signed-off-by: Jean Schmidt <contato@jschmidt.me>
…roject#23840) Signed-off-by: Jean Schmidt <contato@jschmidt.me>
…roject#23840) Signed-off-by: Jean Schmidt <contato@jschmidt.me>
…roject#23840) Signed-off-by: Jean Schmidt <contato@jschmidt.me>
Purpose
Adds the file
.github/scale_config.ymlwith the definition of the runners meta will be providing for Github Actions.Test Plan
N/A
Test Result
N/A