[Bugfix] Fix task field initialization when PYTHONOPTIMIZE is enabled #23718
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a crash that occurs when PYTHONOPTIMIZE is enabled by moving a variable assignment out of an assert statement. This is a good fix for the immediate problem. My review includes a suggestion to further improve the code's robustness by replacing the assert statement with a standard conditional check. This ensures that input validation is always performed, even in optimized environments, which is a better practice for handling user-provided data.
cndoit18
force-pushed
the
fix-pythonoptimize-task-field-init
branch
3 times, most recently
from
a6a0f93 to
0d3b8da
Compare
cndoit18
force-pushed
the
fix-pythonoptimize-task-field-init
branch
from
0d3b8da to
f9be1d5
Compare
This change fixes an issue where enabling PYTHONOPTIMIZE would cause the task field to not be initialized properly, leading to crashes. Signed-off-by: cndoit18 <cndoit18@outlook.com>
cndoit18
force-pushed
the
fix-pythonoptimize-task-field-init
branch
from
f9be1d5 to
7b8371d
Compare
github-actions
bot
added
the
ready
…vllm-project#23718) Signed-off-by: cndoit18 <cndoit18@outlook.com>
…vllm-project#23718) Signed-off-by: cndoit18 <cndoit18@outlook.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…vllm-project#23718) Signed-off-by: cndoit18 <cndoit18@outlook.com>
…vllm-project#23718) Signed-off-by: cndoit18 <cndoit18@outlook.com>
…vllm-project#23718) Signed-off-by: cndoit18 <cndoit18@outlook.com>
2 participants
This change fixes an issue where enabling PYTHONOPTIMIZE would cause the task field to not be initialized properly, leading to crashes.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.