[Bug] Fix DeepGEMM Env Control #23591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yewentao256 <zhyanwentao@126.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fix to ensure that the VLLM_USE_DEEP_GEMM environment variable correctly controls the usage of DeepGEMM for FP8 linear layers. The change adds a check for this environment variable in the should_use_deepgemm_for_fp8_linear function, making its behavior consistent with other DeepGEMM-powered components in vLLM. The implementation is correct and effectively addresses the described bug. My review found no issues with the proposed changes.
Member
|
Should we put it in the base check? I'm not sure where else these functions are called |
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Member
Author
Fixed, thanks! |
mgoin
approved these changes
Aug 26, 2025
tc-mb
pushed a commit
to tc-mb/vllm
that referenced
this pull request
Aug 27, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: tc-mb <caitianchi@modelbest.cn>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We don't let deepgemm env to control fp8 linear, this PR fixes the bug